Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when starting Topic Viewer #574

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Sep 21, 2023

🦟 Bug fix

Summary

Starting the Topic Viewer in gz-sim causes a crash for me. The crash only seems to happen in one of my machines, so it might not be easy to reproduce.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Sep 21, 2023
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #574 (8d0515a) into gz-gui8 (c01d327) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 8d0515a differs from pull request most recent head c517328. Consider uploading reports for the commit c517328 to get more accurate results

@@             Coverage Diff             @@
##           gz-gui8     #574      +/-   ##
===========================================
+ Coverage    68.10%   68.11%   +0.01%     
===========================================
  Files           38       38              
  Lines         5367     5369       +2     
===========================================
+ Hits          3655     3657       +2     
  Misses        1712     1712              
Files Changed Coverage Δ
src/plugins/topic_viewer/TopicViewer.cc 80.89% <100.00%> (+0.24%) ⬆️

Copy link
Contributor

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think eventually we should revisit this plugin and also consider visualize subscribers.

@azeey azeey added the beta Targeting beta release of upcoming collection label Sep 21, 2023
@azeey azeey merged commit 63ed9ea into gazebosim:gz-gui8 Sep 21, 2023
7 of 9 checks passed
@azeey azeey deleted the fix_topic_viewer_crassh branch September 21, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants