Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Workflow updates #59

Merged
merged 4 commits into from
May 14, 2020
Merged

[master] Workflow updates #59

merged 4 commits into from
May 14, 2020

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented May 8, 2020


⚠️ This is using this PR, change to master once that's merged: gazebo-tooling/action-gz-ci#7

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@github-actions github-actions bot added the 🔮 dome Ignition Dome label May 8, 2020
@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@c14dc67). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #59   +/-   ##
=========================================
  Coverage          ?   14.71%           
=========================================
  Files             ?       13           
  Lines             ?     1318           
  Branches          ?        0           
=========================================
  Hits              ?      194           
  Misses            ?     1124           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c14dc67...d412c56. Read the comment docs.

Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Copy link

@JShep1 JShep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I added a small suggestion, are we going to eventually rename bitbucket-pipelines.yml ?

README.md Outdated Show resolved Hide resolved
@chapulina
Copy link
Contributor Author

are we going to eventually rename bitbucket-pipelines.yml ?

Our Jenkins CI still relies on it, so we can't remove it just yet. I ticketed an issue: gazebo-tooling/release-tools#203

Signed-off-by: Louise Poubel <louise@openrobotics.org>

Co-authored-by: John <john@openrobotics.org>
@chapulina chapulina merged commit c3dc272 into master May 14, 2020
@chapulina chapulina deleted the workflow_updates_master branch May 14, 2020 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants