Adding cone primitives. #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 15, 2024
|
do you mind merging this branch with |
|
optional: we could update the marker example to draw a cone shape |
Squashing commits to make requested target of main with backports to harmonic. Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
bperseghetti
force-pushed
the
pr-cone-main
branch
from
754ca30
to
18d7cd5
Compare
rebased on main and force-pushed
Yeah, I suppose we could do that, although I might prefer to add anything else in a follow on PR just so I can limit the scope of this and get it in as fast as possible as we all really need this in harmonic and that still requires a backport. |
|
@scpeters @azeey all good for this getting merged? Any way that we can get the nightly for this also updated so I can get the gazebosim/gz-sim#2410 in as well? Then I can start the backport process. |
iche033
approved these changes
Jun 14, 2024
8 tasks
bperseghetti
added a commit
to rudislabs/gz-gui
that referenced
this pull request
Jun 17, 2024
Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
bperseghetti
added a commit
to rudislabs/gz-gui
that referenced
this pull request
Jun 19, 2024
Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
iche033
pushed a commit
that referenced
this pull request
Jun 20, 2024
Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
This helps add the missing cone geometry for primitive/basic parametric shapes:
And is also valuable for visualizations of emitters/source that typically have conic-based spread as seen in this acoustic attack on an IMU by showing the affected area:
Associated PRs:
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.