Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose shadow texture size for directional lighting in SDF #633

Merged
merged 12 commits into from
Aug 21, 2024
Merged

Expose shadow texture size for directional lighting in SDF #633

merged 12 commits into from
Aug 21, 2024

Commits on Aug 15, 2024

  1. Expose texsize in sdf 

    Signed-off-by: Athena Z <athenaz@google.com>
    @athenaz2
    athenaz2 committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    f2d91de View commit details
    Browse the repository at this point in the history

  2. For clarity, renamed func/vars and modified SDF structure 

    Signed-off-by: Athena Z <athenaz@google.com>
    @athenaz2
    athenaz2 committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    d6a8e19 View commit details
    Browse the repository at this point in the history

  3. Add LightType as func param 

    Signed-off-by: Athena Z <athenaz@google.com>
    @athenaz2
    athenaz2 committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    e5ad171 View commit details
    Browse the repository at this point in the history

  4. Cleaned up debug print statements 

    Signed-off-by: Athena Z <athenaz@google.com>
    @athenaz2
    athenaz2 committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    7648044 View commit details
    Browse the repository at this point in the history

  5. Cleaned up style with codecheck 

    Signed-off-by: Athena Z <athenaz@google.com>
    @athenaz2
    athenaz2 committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    ebf0f41 View commit details
    Browse the repository at this point in the history

  6. Add unit tests and redid some logic 

    Signed-off-by: Athena Z <athenaz@google.com>
    @athenaz2
    athenaz2 committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    b0f29b0 View commit details
    Browse the repository at this point in the history

  7. Fix gzerr print statement 

    Signed-off-by: Athena Z <athenaz@google.com>
    @athenaz2
    athenaz2 committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    acea8e3 View commit details
    Browse the repository at this point in the history

  8. Modify SetShadowTextureSize to return false, add gzerr if it returns … 

    …false; update names of enum vals used

Signed-off-by: Athena Z <athenaz@google.com>
    @athenaz2
    athenaz2 committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    1532f75 View commit details
    Browse the repository at this point in the history

  9. Codecheck style 

    Signed-off-by: Athena Z <athenaz@google.com>
    @athenaz2
    athenaz2 committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    e06172b View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Athena Z. <athenaz@google.com>
    @athenaz2 @iche033
    athenaz2 and iche033 committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    5bf2d70 View commit details
    Browse the repository at this point in the history

  2. Add doxygen comment, fix codecheck/format 

    Signed-off-by: Athena Z <athenaz@google.com>
    @athenaz2
    athenaz2 committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    0bc87f8 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Merge branch 'main' into athenaz/texsize_in_sdf

    @iche033
    iche033 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    9d8c7c8 View commit details
    Browse the repository at this point in the history