-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move each plugin to its own directory #64
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
=======================================
Coverage 14.56% 14.56%
=======================================
Files 13 13
Lines 1332 1332
=======================================
Hits 194 194
Misses 1138 1138
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow this is so neat! much easier to understand the structure now 🤩 I still need to try it locally, but seems like the CIs are failing. Missing dependency in CMakeLists.txt
?
1: [GUI] [Err] [Application.cc:369] Failed to load plugin [TestBadInheritancePlugin] : couldn't get [ignition::gui::Plugin] interface.
1: [GUI] [Err] [Application.cc:333] Failed to load plugin [TestNotRegisteredPlugin] : couldn't load library on path [/var/lib/jenkins/workspace/ignition_gui-ci-pr_any-ubuntu_auto-amd64/build/lib/libTestNotRegisteredPlugin.so].
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks for refactoring!
Those error messages are expected, because those tests are making sure that we properly handle invalid plugins and don't crash. I see some builds list these lines as "problems" though, so I ticketed an issue for that: gazebo-tooling/release-tools#205 |
I see. I was able to build locally with no error -> approval |
Builds on top of #63
We were not installing plugin headers, so there's no need for them to be in the
include
folder.This pull request also moves each plugin into its own directory so the code is more organized and we can more cleanly add plugins with multiple files.
The new
ign_gui_add_plugin
function helps reduce the boilerplate for each plugin.Other changes:
Requester
andResponder
cc files since those plugins were not being compiled.CC @claireyywang and @AmrElsersy