Scroll bar adjustment #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Shepherd <john@openrobotics.org>
chapulina
approved these changes
Jul 31, 2020
There was a problem hiding this comment.
LGTM. The scrollbar is disappearing on dark mode. This change fixes it, but that's also on #84 , so we could just wait for that PR to make this change.
diff --git a/include/ignition/gui/qml/IgnSplit.qml b/include/ignition/gui/qml/IgnSplit.qml
index f5a8906..45cf3f1 100644
--- a/include/ignition/gui/qml/IgnSplit.qml
+++ b/include/ignition/gui/qml/IgnSplit.qml
@@ -283,6 +283,7 @@ SplitView {
*/
Rectangle {
id: splitWrapper
+ color: "transparent"
/**
* Expose the split view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gazebosim/gz-sim#99
Fixes a pre-existing issue with the scroll bar for the overall plugin side bar interfering with each plugin's individual scroll bar. I made the overall scroll bar visible, and made a small space on the right hand side for it to reside.