-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support particle_emitters in the websocket server #104
Conversation
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me, I was able to see the particles in the web app
Codecov Report
@@ Coverage Diff @@
## ign-launch3 #104 +/- ##
============================================
Coverage 30.24% 30.24%
============================================
Files 3 3
Lines 734 734
============================================
Hits 222 222
Misses 512 512 Continue to review full report at Codecov.
|
🎉 New feature
Summary
Adds a call to service provided by ParticleEmitter2 in the websocket plugin. This call supports returning the list of particle emitters to a client, such as gz3d.
This functionality will be deprecated in Ignition Fortress. Users will be able to rely on the Scene message from Ignition Fortress on.
This is part of a series of pull requests designed to support particle emitter in gz3d.
See also:
Addedparticle_emitter
vector message gz-msgs#149Particle emitter sdformat#528Test it
Run the web application using both:
Using
websocket.ign
andfog.sdf
from https://gist.github.com/nkoenig/cd3f5cbf69be97f04190e3cfaa155423:ign launch -v 4 websocket.ign
/visualize
route on the web app, and click connect.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge