ign -> gz Namespace migration (narrow) : gz-math #431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
~~~ sed -i -e 's@namespace gazebo@namespace math@' \ $(grep -rlI namespace\ gazebo src/python_pybind11/) ~~~ Also convert an ignition::gazebo -> ignition::math Signed-off-by: Steve Peters <scpeters@openrobotics.org>
~~~ sed -i -e 's@namespace ignition@namespace gz@g' \ $(grep -rlI 'namespace ignition' .) ~~~ Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
scpeters
force-pushed
the
scpeters/narrow_namespace_migration
branch
from
ac47eec
to
203cf56
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
scpeters
force-pushed
the
scpeters/narrow_namespace_migration
branch
from
203cf56
to
c4629ec
Compare
|
#430 got in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Part of gazebo-tooling/release-tools#711, more narrow alternative to #430
Summary
This is an alternative to #430 (actually using some commits from that branch) that is narrower in scope. It avoids most macro changes in an attempt to simplify the review process.
Once these namespace changes start being merged, things will break, so we will try to merge them all relatively close together in time.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.