Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trivial typo in command line help message #191

Merged
merged 2 commits into from
Oct 18, 2021

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Oct 18, 2021

Signed-off-by: Nate Koenig nate@openrobotics.org

🦟 Bug fix

Summary

Redo of #188

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig nkoenig requested a review from caguero as a code owner October 18, 2021 17:43
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Oct 18, 2021
@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #191 (63e4c17) into ign-msgs5 (bf0db74) will not change coverage.
The diff coverage is n/a.

❗ Current head 63e4c17 differs from pull request most recent head 80465af. Consider uploading reports for the commit 80465af to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           ign-msgs5     #191   +/-   ##
==========================================
  Coverage      84.38%   84.38%           
==========================================
  Files              7        7           
  Lines            807      807           
==========================================
  Hits             681      681           
  Misses           126      126           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf0db74...80465af. Read the comment docs.

@nkoenig nkoenig merged commit a89c15d into ign-msgs5 Oct 18, 2021
@nkoenig nkoenig deleted the nkoenig/cmd_list_typo branch October 18, 2021 18:34
chapulina added a commit that referenced this pull request Oct 18, 2021
* 🎈 5.8.0 (#173)

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* 🥳 Update ign-tools issue on README (#184)

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* Fix trivial typo in command line help message (#191)

* Fix trivial typo in command line help message

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* Remove comment

Signed-off-by: Nate Koenig <nate@openrobotics.org>

Co-authored-by: Nate Koenig <nate@openrobotics.org>

Co-authored-by: Louise Poubel <louise@openrobotics.org>
Co-authored-by: Nate Koenig <nate@openrobotics.org>
nkoenig added a commit that referenced this pull request Oct 19, 2021
* 🎈 5.8.0 (#173)

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* 🥳 Update ign-tools issue on README (#184)

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* Fix trivial typo in command line help message (#191)

* Fix trivial typo in command line help message

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* Remove comment

Signed-off-by: Nate Koenig <nate@openrobotics.org>

Co-authored-by: Nate Koenig <nate@openrobotics.org>

Co-authored-by: Louise Poubel <louise@openrobotics.org>
Co-authored-by: Nate Koenig <nate@openrobotics.org>
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1

@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-25-fortress-edifice-citadel/1343/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants