Add message definitions for the parameter component #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## ign-msgs8 #241 +/- ##
==========================================
Coverage 85.38% 85.38%
==========================================
Files 9 9
Lines 951 951
==========================================
Hits 812 812
Misses 139 139 Continue to review full report at Codecov.
|
mjcarroll
reviewed
Apr 11, 2022
10 tasks
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
* Update copyright year 2021->2022. Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
ivanpauno
force-pushed
the
ivanpauno/parameters-component8
branch
from
c1510f7
to
933c1e9
Compare
Codecov Report
@@ Coverage Diff @@
## ign-msgs8 #241 +/- ##
==========================================
Coverage 96.64% 96.64%
==========================================
Files 9 9
Lines 953 953
==========================================
Hits 921 921
Misses 32 32 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
… into ivanpauno/parameters-component8
caguero
reviewed
Jul 11, 2022
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
caguero
approved these changes
Aug 4, 2022
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
|
@caguero friendly ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
Add message definitions to be used by the ignition transport parameter component.
See gazebosim/gz-transport#305.
Test it
See gazebosim/gz-sim#1431 for details of a demo.
Replaces #211.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.