Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge ign-msgs5 ➡️ ign-msgs8 #307

Merged
merged 3 commits into from
Sep 28, 2022
Merged

Merge ign-msgs5 ➡️ ign-msgs8 #307

merged 3 commits into from
Sep 28, 2022

Conversation

scpeters
Copy link
Member

➡️ Forward port

Port ign-msgs5 ➡️ ign-msgs8

Branch comparision: ign-msgs8...ign-msgs5

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Sep 27, 2022
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #307 (4299d89) into ign-msgs8 (839e1fd) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           ign-msgs8     #307   +/-   ##
==========================================
  Coverage      96.64%   96.64%           
==========================================
  Files              9        9           
  Lines            953      953           
==========================================
  Hits             921      921           
  Misses            32       32           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@scpeters
Copy link
Member Author

there are some redirection headers missing; I don't think this is ready

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Member Author

there are some redirection headers missing; I don't think this is ready

should be fixed by 4299d89

I think it's ready now

Copy link
Contributor

@methylDragon methylDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright and CI is green

@scpeters scpeters merged commit 66ae6cc into ign-msgs8 Sep 28, 2022
@scpeters scpeters deleted the scpeters/merge_5_8 branch September 28, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants