Adds a message that allows loading environments via a topic #320

arjo129 · 2022-12-20T14:12:23Z

🦟 Bug fix

Fixes #

Summary

Signed-off-by: Arjo Chakravarty arjo@openrobotics.org

Checklist

Signed all commits for DCO
Added tests
Updated documentation (as needed)
Updated migration guide (as needed)
Consider updating Python bindings (if the library has them)
codecheck passed (See contributing)
All tests passed (See test coverage)
While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

include/gz/msgs/Utility.hh

proto/gz/msgs/data_load_options.proto

codecov · 2022-12-20T14:32:11Z

Codecov Report

Merging #320 (5d3797f) into gz-msgs9 (c7e0323) will increase coverage by 0.15%.
The diff coverage is 100.00%.

❗ Current head 5d3797f differs from pull request most recent head 97531a0. Consider uploading reports for the commit 97531a0 to get more accurate results

@@             Coverage Diff              @@
##           gz-msgs9     #320      +/-   ##
============================================
+ Coverage     95.41%   95.57%   +0.15%     
============================================
  Files            10       10              
  Lines          1026     1062      +36     
============================================
+ Hits            979     1015      +36     
  Misses           47       47

Files Changed	Coverage Δ
src/Utility.cc	`99.02% <100.00%> (+0.05%)`	⬆️

caguero · 2022-12-20T15:12:44Z

include/gz/msgs/Utility.hh

@@ -212,6 +220,14 @@ namespace gz
    msgs::SphericalCoordinates Convert(
        const math::SphericalCoordinates &_coord);

+    /// \brief Convert a msgs::SphericalCoordinatesType to an
+    /// gz::math::SphericalCoordinates::CoordinateTpye
+    /// \param[in] _coord The spherical coordinates to convert


The spherical coordinate type ...

include/gz/msgs/Utility.hh

proto/gz/msgs/data_load_options.proto

src/Utility.cc

caguero · 2022-12-20T15:17:49Z

src/Utility.cc

+        case math::SphericalCoordinates::CoordinateType::LOCAL:
+          return  msgs::SphericalCoordinatesType::LOCAL;
+        case math::SphericalCoordinates::CoordinateType::LOCAL2:
+          return msgs::SphericalCoordinatesType::LOCAL2;


This block returns a warning as we don't return anything if none of the previous conditions are met.

caguero

Tiny comment, otherwise looks good to me.

proto/gz/msgs/data_load_options.proto

Required by gazebosim/gz-sim#1842 Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>

Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>

arjo129 · 2023-01-25T03:19:13Z

I suggest holding off on merging this till gazebosim/gz-sim#1842 is complete.

…ment_data_messages

Review stale.

proto/gz/msgs/data_load_options.proto

Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>

mjcarroll

There are some open comments from Carlos here, if you could address them.

Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>

arjo129 · 2023-05-17T04:37:34Z

@mjcarroll I've addressed the issues. It's waiting on a ✔️ from you.

azeey · 2023-08-25T15:41:33Z

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

This was merged with "Merge commit". Let's remember to use "Squash-Merge" next time.

arjo129 requested a review from caguero as a code owner December 20, 2022 14:12

github-actions bot added the 🌱 garden Ignition Garden label Dec 20, 2022

arjo129 mentioned this pull request Dec 20, 2022

Fix enviroment system loading mechanism gazebosim/gz-sim#1842

Merged

9 tasks

ahcorde previously requested changes Dec 20, 2022

View reviewed changes

include/gz/msgs/Utility.hh Outdated Show resolved Hide resolved

proto/gz/msgs/data_load_options.proto Outdated Show resolved Hide resolved

caguero reviewed Dec 20, 2022

View reviewed changes

caguero approved these changes Jan 20, 2023

View reviewed changes

proto/gz/msgs/data_load_options.proto Outdated Show resolved Hide resolved

arjo129 added 6 commits January 25, 2023 03:17

Adds a message that allows loading environments via a topic

f4b43a5

Required by gazebosim/gz-sim#1842 Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>

style

56b157a

Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>

Address PR feedback.

303df10

Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>

Style

2475c08

Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>

coverage

9b39a6d

Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>

style

cc4ce08

Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>

arjo129 force-pushed the arjo/feat/environment_data_messages branch from a89aee2 to cc4ce08 Compare January 25, 2023 03:17

Merge remote-tracking branch 'origin/gz-msgs9' into arjo/feat/environ…

940b2db

…ment_data_messages

arjo129 requested a review from ahcorde February 28, 2023 00:27

ahcorde requested changes Feb 28, 2023

View reviewed changes

proto/gz/msgs/data_load_options.proto Outdated Show resolved Hide resolved

arjo129 and others added 2 commits March 1, 2023 09:18

Bump copyright

4c60886

Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>

Merge branch 'gz-msgs9' into arjo/feat/environment_data_messages

e4129c9

arjo129 requested a review from ahcorde April 17, 2023 02:34

arjo129 enabled auto-merge April 18, 2023 06:59

mjcarroll requested changes Apr 26, 2023

View reviewed changes

arjo129 added 4 commits May 9, 2023 06:46

Address PR feedback

8c0e400

Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>

Coverage

c1766cf

Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>

Get rid of compiler

101a723

Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>

Style

bc90bd5

Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>

arjo129 requested a review from mjcarroll May 10, 2023 02:38

ahcorde approved these changes May 10, 2023

View reviewed changes

mabelzhang mentioned this pull request Jun 21, 2023

Adds a tutorial explaining how to use Environmental Data infrastructure. gazebosim/gz-sim#1806

Open

azeey added the beta Targeting beta release of upcoming collection label Jul 31, 2023

Merge branch 'gz-msgs9' into arjo/feat/environment_data_messages

97531a0

mjcarroll approved these changes Aug 4, 2023

View reviewed changes

arjo129 merged commit 7fc5805 into gz-msgs9 Aug 4, 2023
8 checks passed

arjo129 deleted the arjo/feat/environment_data_messages branch August 4, 2023 21:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds a message that allows loading environments via a topic #320

Adds a message that allows loading environments via a topic #320

arjo129 commented Dec 20, 2022 •

edited

Loading

codecov bot commented Dec 20, 2022 •

edited

Loading

caguero Dec 20, 2022

caguero Dec 20, 2022 •

edited

Loading

caguero left a comment

arjo129 commented Jan 25, 2023

mjcarroll left a comment

arjo129 commented May 17, 2023

azeey commented Aug 25, 2023

Adds a message that allows loading environments via a topic #320

Adds a message that allows loading environments via a topic #320

Conversation

arjo129 commented Dec 20, 2022 • edited Loading

🦟 Bug fix

Summary

Checklist

codecov bot commented Dec 20, 2022 • edited Loading

Codecov Report

caguero Dec 20, 2022

Choose a reason for hiding this comment

caguero Dec 20, 2022 • edited Loading

Choose a reason for hiding this comment

caguero left a comment

Choose a reason for hiding this comment

arjo129 commented Jan 25, 2023

mjcarroll left a comment

Choose a reason for hiding this comment

arjo129 commented May 17, 2023

azeey commented Aug 25, 2023

arjo129 commented Dec 20, 2022 •

edited

Loading

codecov bot commented Dec 20, 2022 •

edited

Loading

caguero Dec 20, 2022 •

edited

Loading