Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport Citadel] Included autogenerated code to the ign_create_docs function (#76) #78

Merged
merged 1 commit into from
Aug 20, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Aug 18, 2020

According with the collection-citadel.yaml file the version of ign-msgs for Citadel is ign-msgs5 . But on the website I can see ign-msgs6. Is this an error?

Targeting branch ign-msgs5

Signed-off-by: ahcorde ahcorde@gmail.com

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde added the documentation Improvements or additions to documentation label Aug 18, 2020
@ahcorde ahcorde requested a review from caguero August 18, 2020 06:51
@ahcorde ahcorde self-assigned this Aug 18, 2020
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Aug 18, 2020
@chapulina
Copy link
Contributor

But on the website I can see ign-msgs6

I see 5.x 🧐 Maybe you looked at the line above that says 6.x for math?

@chapulina
Copy link
Contributor

@osrf-jenkins run tests please

@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #78 into ign-msgs5 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-msgs5      #78   +/-   ##
==========================================
  Coverage      85.66%   85.66%           
==========================================
  Files              7        7           
  Lines            795      795           
==========================================
  Hits             681      681           
  Misses           114      114           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 457653b...91e5fe9. Read the comment docs.

@ahcorde
Copy link
Contributor Author

ahcorde commented Aug 19, 2020

I see 5.x Maybe you looked at the line above that says 6.x for math?

ups! It's fine.

@chapulina chapulina merged commit e56cde5 into ign-msgs5 Aug 20, 2020
@chapulina chapulina deleted the ahcorde/backport/76 branch August 20, 2020 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants