Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advanced tutorial: Implement physics engine as a plugin #144

Merged
merged 6 commits into from
Nov 6, 2020
Merged

Advanced tutorial: Implement physics engine as a plugin #144

merged 6 commits into from
Nov 6, 2020

Conversation

anindex
Copy link
Contributor

@anindex anindex commented Oct 22, 2020

Signed-off-by: anindex an.thai.le97@gmail.com

@anindex
Initial draft implementing feature in TPE
04c1d4b 
Signed-off-by: anindex <an.thai.le97@gmail.com>
@anindex anindex requested a review from mxgrey as a code owner October 22, 2020 14:42
@chapulina chapulina added the documentation Improvements or additions to documentation label Oct 22, 2020
@claireyywang claireyywang mentioned this pull request Oct 24, 2020
Closed
claireyywang
claireyywang suggested changes Oct 24, 2020
View reviewed changes
Copy link
Contributor

@claireyywang claireyywang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a first pass review. I think we have all the content, just need to re-organize them a little bit to be more succinct and easy to follow.

tutorials/09-set-up-physics-engine-tpe.md Outdated Show resolved Hide resolved
tutorials.md.in Outdated Show resolved Hide resolved
tutorials/09-set-up-physics-engine-tpe.md Outdated Show resolved Hide resolved
tutorials/09-set-up-physics-engine-tpe.md Outdated Show resolved Hide resolved
tutorials/09-set-up-physics-engine-tpe.md Outdated Show resolved Hide resolved
tutorials/09-set-up-physics-engine-tpe.md Outdated Show resolved Hide resolved
tutorials/09-set-up-physics-engine-tpe.md Outdated Show resolved Hide resolved
tutorials/09-set-up-physics-engine-tpe.md Outdated Show resolved Hide resolved
tutorials/09-set-up-physics-engine-tpe.md Outdated Show resolved Hide resolved
tutorials/09-set-up-physics-engine-tpe.md Outdated Show resolved Hide resolved
@claireyywang claireyywang self-assigned this Oct 24, 2020
@claireyywang claireyywang removed the request for review from mxgrey October 24, 2020 05:24
@claireyywang claireyywang self-requested a review November 5, 2020 18:33
claireyywang
claireyywang approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@claireyywang claireyywang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@claireyywang claireyywang merged commit f78de41 into gazebosim:main Nov 6, 2020
claireyywang added a commit that referenced this pull request Jan 7, 2021
@anindex @claireyywang
Advanced tutorial: Implement physics engine as a plugin (#144)
3ac5fdc 
* Initial draft implementing feature in TPE
* Revised tutorial 9
* Fix code in example feature, tested compiling

Co-authored-by: anindex <an.thai.le97@gmail.com>
Co-authored-by: Claire Wang <22240514+claireyywang@users.noreply.github.com>
chapulina pushed a commit that referenced this pull request Jan 21, 2021
@anindex @claireyywang @chapulina
Advanced tutorial: Implement physics engine as a plugin (#144)
8788fe9 
* Initial draft implementing feature in TPE
* Revised tutorial 9
* Fix code in example feature, tested compiling

Co-authored-by: anindex <an.thai.le97@gmail.com>
Co-authored-by: Claire Wang <22240514+claireyywang@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claireyywang claireyywang claireyywang approved these changes

Assignees

@claireyywang claireyywang

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anindex @claireyywang @chapulina