ign -> gz Namespace Migration : gz-physics #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
chapulina
added
the
needs upstream release
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
chapulina
approved these changes
May 20, 2022
include/gz/physics/config.hh.in
Outdated
|
|
||
| #define IGNITION_PHYSICS_ENGINE_INSTALL_DIR "${IGNITION_PHYSICS_ENGINE_INSTALL_DIR}" | ||
| #define GZ_PHYSICS_VERSION_HEADER "Gz Physics, version ${PROJECT_VERSION_FULL}\nCopyright (C) 2022 Open Source Robotics Foundation.\nReleased under the Apache 2.0 License.\n\n" |
There was a problem hiding this comment.
Interesting that it didn't have a header yet, I guess it's because it doesn't have a CLI. It doesn't hurt to add it, I'd just spell out Gazebo and put the year as 2017
Suggested change
| #define GZ_PHYSICS_VERSION_HEADER "Gz Physics, version ${PROJECT_VERSION_FULL}\nCopyright (C) 2022 Open Source Robotics Foundation.\nReleased under the Apache 2.0 License.\n\n" | |
| #define GZ_PHYSICS_VERSION_HEADER "Gazebo Physics, version ${PROJECT_VERSION_FULL}\nCopyright (C) 2017 Open Source Robotics Foundation.\nReleased under the Apache 2.0 License.\n\n" |
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
force-pushed
the
namespace_migration
branch
from
c1967bf
to
f3e283b
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
force-pushed
the
namespace_migration
branch
from
48b4f6c
to
6b0ec66
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
force-pushed
the
namespace_migration
branch
from
8c897e9
to
cc6e1cc
Compare
chapulina
approved these changes
May 27, 2022
|
@osrf-jenkins run tests please! |
Codecov Report
@@ Coverage Diff @@
## main #348 +/- ##
=======================================
Coverage 97.36% 97.36%
=======================================
Files 69 69
Lines 1328 1328
=======================================
Hits 1293 1293
Misses 35 35 Continue to review full report at Codecov.
|
chapulina
removed
the
needs upstream release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See gazebo-tooling/release-tools#711