Added Simulation features common test #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
|
@osrf-jenkins run tests please! |
Signed-off-by: ahcorde <ahcorde@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #362 +/- ##
==========================================
+ Coverage 74.73% 76.74% +2.00%
==========================================
Files 128 128
Lines 5628 5628
==========================================
+ Hits 4206 4319 +113
+ Misses 1422 1309 -113
Continue to review full report at Codecov.
|
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
mjcarroll
reviewed
Jun 22, 2022
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
…into ahcorde/6/simulation_features
…into ahcorde/6/simulation_features
Signed-off-by: ahcorde <ahcorde@gmail.com>
mjcarroll
approved these changes
Jul 8, 2022
test/common_test/CMakeLists.txt
Outdated
| @@ -3,6 +3,7 @@ set(TEST_TYPE "COMMON_TEST") | |||
| set(tests | |||
| basic_test | |||
| construct_empty_world | |||
| simulation_features | |||
| ) | |||
|
|
|||
| link_directories(${PROJECT_BINARY_DIR}/test) | |||
There was a problem hiding this comment.
Not related to this PR, but link_directories probably isn't necessary here?
| gz::physics::GetCylinderShapeProperties, | ||
| gz::physics::GetCapsuleShapeProperties, | ||
| gz::physics::GetEllipsoidShapeProperties | ||
| >; |
There was a problem hiding this comment.
Can these be grouped into feature lists that can be reused?
There was a problem hiding this comment.
I will create granular tests in a follow up PR
Signed-off-by: ahcorde <ahcorde@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ahcorde ahcorde@gmail.com
🎉 New feature
Summary
Added Simulation features common test
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.