Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5 ➡️ 6 #467

Merged
merged 3 commits into from
Jan 9, 2023
Merged

5 ➡️ 6 #467

merged 3 commits into from
Jan 9, 2023

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Jan 6, 2023

➡️ Forward port

Port ign-physics5 to gz-physics6

Branch comparison: gz-physics6...ign-physics5

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

scpeters and others added 2 commits October 10, 2022 09:42
Backport gazebosim#436.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Co-authored-by: Steve Peters <scpeters@openrobotics.org>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jan 6, 2023
@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #467 (f0b2012) into gz-physics6 (2a93515) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           gz-physics6     #467   +/-   ##
============================================
  Coverage        75.43%   75.43%           
============================================
  Files              140      140           
  Lines             7099     7099           
============================================
  Hits              5355     5355           
  Misses            1744     1744           
Impacted Files Coverage Δ
dartsim/src/Base.hh 96.71% <ø> (ø)
dartsim/src/SimulationFeatures.cc 94.44% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@scpeters
Copy link
Member

scpeters commented Jan 6, 2023

this commit is a little weird. It doesn't look like a merge commit and I don't see a commit message about the actual changes

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey
Copy link
Contributor Author

azeey commented Jan 6, 2023

Not sure what happened. I think it's fixed now.

Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with clean CI

@ahcorde ahcorde merged commit f9d7e1b into gazebosim:gz-physics6 Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants