Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setting OpenGL_GL_PREFERENCE in cmake #1041

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Remove setting OpenGL_GL_PREFERENCE in cmake #1041

merged 2 commits into from
Aug 20, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Aug 20, 2024

🦟 Bug fix

Summary

This is no longer necessary now that we require a newer version of CMake, see gazebosim/gz-sensors#457 (comment)

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Aug 20, 2024
@iche033 iche033 merged commit 6611f3b into main Aug 20, 2024
8 of 9 checks passed
@iche033 iche033 deleted the gl_pref branch August 20, 2024 20:13
@scpeters
Copy link
Member

thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants