Updated to work with ign-plugin

[ahcorde]

This PR depends and needs a release from this other PR gazebosim/gz-plugin#30

All the symbols are loaded in the executable because of the RTLD_GLOBAL. This logic will filter the symbols

Signed-off-by: ahcorde ahcorde@gmail.com

[codecov]

Codecov Report

Merging #171 (56250d6) into main (e34fa79) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #171   +/-   ##
=======================================
  Coverage   52.07%   52.07%           
=======================================
  Files         143      143           
  Lines       13105    13108    +3     
=======================================
+ Hits         6824     6826    +2     
- Misses       6281     6282    +1     

Impacted Files	Coverage Δ
src/RenderEngineManager.cc	76.59% <100.00%> (+0.37%)	⬆️
...e/ignition/rendering/base/BaseGaussianNoisePass.hh	96.66% <0.00%> (-3.34%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e34fa79...56250d6. Read the comment docs.

[chapulina]

Let me just check if I understood why this PR is needed. If gazebosim/gz-plugin#30 gets in, ign-rendering won't work properly anymore unless this filtering is done?

This sounds like a breaking change on ign-plugin, that will required a major version bump on that library.

I'm also curious about what other pluginNames are showing up here that don't contain rendering. Do you remember?

[ahcorde]

Yes, this may require some more mayor version bumps: ign-gazebo, ign-gui, ign-rendering, sensors.

I'm also curious about what other pluginNames are showing up here that don't contain rendering. Do you remember?

I will check it.

[chapulina]

With the proposal on gazebosim/gz-plugin#35, I think this PR isn't necessary.

[chapulina]

Since #236, we're looking explicitly for plugins that implement the ignition::rendering::RenderEnginePlugin interface, and in case we find several, we load the first one and print a warning to the user.

So I'm closing this one because I think it is no longer necessary. Please speak up if you think otherwise, @ahcorde .