Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 4 0 prep #242

Merged
merged 4 commits into from
Feb 10, 2021
Merged

4 4 0 prep #242

merged 4 commits into from
Feb 10, 2021

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Feb 10, 2021

Summary

Prepares for 4.4.0 release and merges ign-rendering3 forward.

ignition-rendering4_4.3.1...ign-rendering4

Checklist

iche033 and others added 4 commits February 3, 2021 13:17
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Feb 10, 2021
@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #242 (77a8f82) into ign-rendering4 (269f9ed) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           ign-rendering4     #242      +/-   ##
==================================================
- Coverage           52.87%   52.86%   -0.01%     
==================================================
  Files                 143      143              
  Lines               13522    13522              
==================================================
- Hits                 7150     7149       -1     
- Misses               6372     6373       +1     
Impacted Files Coverage Δ
ogre2/src/Ogre2GpuRays.cc 94.24% <100.00%> (ø)
...e/ignition/rendering/base/BaseGaussianNoisePass.hh 96.66% <0.00%> (-3.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 269f9ed...77a8f82. Read the comment docs.

@adlarkin
Copy link
Contributor

I'm working on fixing a test case in gazebosim/gz-sim#614. I haven't confirmed the source of the issue yet, but I believe it may be in #235. We can either make this release now and then follow it up with a potential patch release, or wait to make a release if I can confirm that #235 is the source of the issue I'm seeing in gazebosim/gz-sim#614.

@nkoenig
Copy link
Contributor Author

nkoenig commented Feb 10, 2021

I'm working on fixing a test case in ignitionrobotics/ign-gazebo#614. I haven't confirmed the source of the issue yet, but I believe it may be in #235. We can either make this release now and then follow it up with a potential patch release, or wait to make a release if I can confirm that #235 is the source of the issue I'm seeing in ignitionrobotics/ign-gazebo#614.

We have chatted in a side channel and agreed to make the release with a patch release in the future.

@nkoenig nkoenig merged commit f9ddcea into ign-rendering4 Feb 10, 2021
@nkoenig nkoenig deleted the 4-4-0-prep branch February 10, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants