Fix race condition when rendering the UI (#304) #307
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix also depends on on a fix in ign-gazebo so that it now can call SwapFromThread, otherwise the race condition will still happen. At the current moment, the implementation is very wasteful creating many more RenderTargets than needed (because 2 workspaces are created). This issue will be fixed in the next commit Affects gazebosim#304 Signed-off-by: Matias N. Goldberg <dark_sylinc@yahoo.com.ar>
1 task
5 tasks
|
Hi @darksylinc, are you still planning to work on this PR? Let us know how we can help. Thanks! |
|
Hi! Not at the time. The race condition was fixed by another PR. The PR that fixed it forced serialization (which is like brute forcing this thing). This PR wanted to preserve parallelism. However there are several issues unaddressed (synchronizing important events like window resizes, fixing how Qt/Ign threads pass around data to avoid potential deadlocks), our efforts are being focused on higher priority tasks. What we have now is "good enough" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fix also depends on on a fix in ign-gazebo so that it now can call
SwapFromThread, otherwise the race condition will still happen.
At the current moment, the implementation is very wasteful creating many
more RenderTargets than needed (because 2 workspaces are created).
This issue will be fixed in the next commit
Affects #304
🦟 Bug fix
Fixes #304
Checklist