Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FSAA in UI and lower VRAM consumption #313

Merged
merged 11 commits into from
Jun 14, 2021

Commits on May 2, 2021

  1. Fix FSAA in UI and lower VRAM consumption

    FSAA was being requested however due to how the compositor was setup,
    this effect was not taking effect.
    
    Additionally, the Compositor setup was improved to lower memory
    consumption. Originally the setup was taken from Ogre samples which
    assume they will ultimately be rendering to a window.
    
    However this is not the case and thus IGN was creating 3 render targets
    (two for ping-ponging between postprocess FXs + one for storing the
    final result)
    This was optimized so that we only create 2 render targets: two for
    ping-ponging between postprocess FXs and we pick at runtime which one is
    storing the final result via the new variable renderTargetResultsIdx
    
    Further performance optimizations could be made in Ogre 2.2 to improve
    unnecessary MSAA resolving when doing postprocess, though considering
    there's currently only one postprocessing effect (the Gaussian filter) I
    doubt this optimization would make much of a difference
    
    Signed-off-by: Matias N. Goldberg <dark_sylinc@yahoo.com.ar>
    darksylinc committed May 2, 2021
    Configuration menu
    Copy the full SHA
    3ef8156 View commit details
    Browse the repository at this point in the history
  2. Add Ogre2RenderTarget::RenderTarget back

    Signed-off-by: Matias N. Goldberg <dark_sylinc@yahoo.com.ar>
    darksylinc committed May 2, 2021
    Configuration menu
    Copy the full SHA
    400811d View commit details
    Browse the repository at this point in the history

Commits on May 8, 2021

  1. Rewrote the compositor changes to support RenderWindows

    As a bonus this new method breaks ABI far less.
    Fix leak: DestroyCompositor would often not be called
    
    Signed-off-by: Matias N. Goldberg <dark_sylinc@yahoo.com.ar>
    darksylinc committed May 8, 2021
    Configuration menu
    Copy the full SHA
    a1c1968 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2021

  1. Mantain ABI compatibility #Ogre2IsRenderWindowABI

    When merging to newer branches that can break the ABI,
    revert this commit
    
    Signed-off-by: Matias N. Goldberg <dark_sylinc@yahoo.com.ar>
    darksylinc committed May 15, 2021
    Configuration menu
    Copy the full SHA
    b52af92 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2021

  1. Fix ABI problems

    I gave up on commit undoing
    
    It's clear that on the next release, Ogre2RenderTarget and
    Ogre2RenderTexture need to be merged together.
    
    Signed-off-by: Matias N. Goldberg <dark_sylinc@yahoo.com.ar>
    darksylinc committed May 23, 2021
    Configuration menu
    Copy the full SHA
    d83468d View commit details
    Browse the repository at this point in the history
  2. Fix camel case convention

    Signed-off-by: Matias N. Goldberg <dark_sylinc@yahoo.com.ar>
    darksylinc committed May 23, 2021
    Configuration menu
    Copy the full SHA
    10d493f View commit details
    Browse the repository at this point in the history

Commits on May 24, 2021

  1. Configuration menu
    Copy the full SHA
    fbcea16 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2021

  1. Make Ogre2RenderTarget::RenderTarget pure virtual again

    Hopefully this will prevent ABI breakage
    
    Signed-off-by: Matias N. Goldberg <dark_sylinc@yahoo.com.ar>
    darksylinc committed May 28, 2021
    Configuration menu
    Copy the full SHA
    40d04d9 View commit details
    Browse the repository at this point in the history
  2. Fix deprecation warnings during build

    Signed-off-by: Matias N. Goldberg <dark_sylinc@yahoo.com.ar>
    darksylinc committed May 28, 2021
    Configuration menu
    Copy the full SHA
    bd4aa2b View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2021

  1. Fix invalid write of size 8

    This was causing heap corruption. At best it would crash. At worst it
    would manifeset in subtle weird behaviors
    
    Signed-off-by: Matias N. Goldberg <dark_sylinc@yahoo.com.ar>
    darksylinc committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    9b01d22 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2e49d36 View commit details
    Browse the repository at this point in the history