UserData methods moved from Visual to Node #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <ahcorde@gmail.com>
This was referenced Jul 2, 2021
Signed-off-by: ahcorde <ahcorde@gmail.com>
chapulina
reviewed
Jul 6, 2021
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
|
there are a couple of clang warnings: |
Signed-off-by: ahcorde <ahcorde@gmail.com>
|
@osrf-jenkins retest this please |
iche033
approved these changes
Jul 14, 2021
|
#361 should fix the github CI failing builds |
chapulina
approved these changes
Jul 15, 2021
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #58
Summary
This PR is part of the effort to consolidate
ign-guiandign-gazebo(related to this conversation gazebosim/gz-gui#231 (comment)) and it also targets this issue #58.The idea is to move the
UserDataandSetUserDatamethods to the Node class. I'm not sure how to proceed about the change in the API if I should tick-tock the methods in the Visual class, this change should not affect the API becauseNodeis a parent class ofVisual, it will break ABI but this PR is targetingmain.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge