Check for OpenGL backend before calling GL APIs #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
8 tasks
iche033
changed the title
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Codecov Report
@@ Coverage Diff @@
## ign-rendering6 #509 +/- ##
==================================================
+ Coverage 55.44% 55.46% +0.02%
==================================================
Files 195 195
Lines 19736 19752 +16
==================================================
+ Hits 10943 10956 +13
- Misses 8793 8796 +3
Continue to review full report at Codecov.
|
|
Checked on macOS / Metal |
chapulina
approved these changes
Dec 10, 2021
ahcorde
pushed a commit
that referenced
this pull request
Dec 14, 2021
* Check for OpenGL backend before calling GL APIs (#509) Signed-off-by: Louise Poubel <louise@openrobotics.org> * Enable selection buffer based ray query and fix test (#510) Signed-off-by: Ian Chen <ichen@osrfoundation.org> * 🎈 6.1.0 (#511) Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Louise Poubel <louise@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Chen ichen@osrfoundation.org
🦟 Bug fix
fixes issue found in this comment: gazebosim/gz-gui#323 (comment)
Summary
Now that here is support for more than just OpenGL graphics API, we should check that the OpenGL render system is actually in use before making GL calls.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge