Disable setting particle emitter color range #903
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Related issue: #902
Summary
Setting the particle emitter color range causes particles to appear black instead of actually changing the color of the particles to the range specified. The problem is that is affecting particle emitters that have also a material set (via
SetMaterial
) - the material diffuse color is overriden and results in black particles.This PR just disables that function for now, see more details in #902
Test with
gz sim -v 4 particle_emitter.sdf
. With these changes, you should now see that the particles on the left side of the scene appears red (the intended color specified in the<material>
tag) instead of black with flickering red.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.