Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz Namespace Migration : gz-sensors #226

Merged
merged 24 commits into from
May 29, 2022
Merged

ign -> gz Namespace Migration : gz-sensors #226

merged 24 commits into from
May 29, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon mentioned this pull request May 18, 2022
Closed
@github-actions github-actions bot added the 🌱 garden Ignition Garden label May 18, 2022
@chapulina chapulina added ign to gz Renaming Ignition to Gazebo. needs upstream release Blocked by a release of an upstream library labels May 18, 2022
chapulina
chapulina approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 🟢 CI

include/gz/sensors/config.hh.in Outdated Show resolved Hide resolved
include/gz/sensors/config.hh.in Outdated Show resolved Hide resolved
@methylDragon methylDragon force-pushed the namespace_migration branch 5 times, most recently from 1a9f2de to f92c7e5 Compare May 20, 2022 10:27
chapulina
chapulina approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 🟢 CI!

@methylDragon
Update header guards
1dd0d55 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate namespaces
9f29194 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Add migration line
00f2f50 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Implement deprecation trick
9794634 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Add deprecation test
aeeb110 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Include config.hh
8032266 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Use pragma deprecation message instead
bee4126 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Ticktock config macros
8295f08 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate inline namespaces
60d3c1b 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Mention gz headers in migration
ee3b529 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate includes to gz
38a6f82 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Update config.hh
5742c1b 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate Export.hh macros, deprecated test, and remove plugin macros
ed7aa56 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate more namespaces
c082d27 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate github links
ddd73e9 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate user-facing Ignition to Gazebo
5dc895c 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate gz-common logging calls
190085c 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Revert plugin names to ignition-gazebo
decd5e9 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Include config.hh in recursive directories and <lib>.hh
fedc7f1 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Gazebo Robotics -> Gazebo
28da6f0 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
ignitionrobotics -> gazebosim
2e85bcc 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Revert migration for fuel.ignitionrobotics.org
878b667 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Rollback osrf-migration.github.io migrations
85231d3 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate igndbg -> gzdbg
1c52479 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

@codecov
Copy link

codecov bot commented May 29, 2022 •
edited
Loading

Codecov Report

Merging #226 (1c52479) into main (d60d832) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #226   +/-   ##
=======================================
  Coverage   80.00%   80.00%           
=======================================
  Files           1        1           
  Lines          15       15           
=======================================
  Hits           12       12           
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d60d832...1c52479. Read the comment docs.

@methylDragon methylDragon merged commit 55c5666 into main May 29, 2022
@methylDragon methylDragon deleted the namespace_migration branch May 29, 2022 02:23
@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@iche033 iche033 Awaiting requested review from iche033 iche033 is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina