-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix msgs.hh uses #263
Fix msgs.hh uses #263
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## gz-sensors7 #263 +/- ##
============================================
Coverage 67.75% 67.75%
============================================
Files 35 35
Lines 3734 3734
============================================
Hits 2530 2530
Misses 1204 1204
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same tests are failing, is this expected?
for homebrew, the same test is failing on gz-sensors7: https://build.osrfoundation.org/view/ign-garden/job/ignition_sensors-ci-gz-sensors7-homebrew-amd64/1/testReport/junit/(root)/INTEGRATION_wide_angle_camera/test_ran/ and for windows, the same 14 tests are failing: https://build.osrfoundation.org/view/ign-garden/job/ign_sensors-gz-7-win/1/ |
ABI checker failure is not relevant until the stable release, but it is failing due to a bug in release-tools: gazebo-tooling/release-tools#808 |
I also see the same Github actions test failures in Jammy on the latest commit to gz-sensors7: da58993 |
homebrew CI builds successfully with this branch (using gazebosim/gz-sim#1566) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI looks reasonable to me
🦟 Bug fix
Required by
Summary
Include the narrowest headers for faster compilation.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸