-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ign with gz in installation tutorial #382
Conversation
Signed-off-by: Ian Chen <ichen@openrobotics.org>
tutorials/install.md
Outdated
@@ -154,9 +154,9 @@ Before [gz-rendering](https://github.com/gazebosim/gz-rendering) becomes availab | |||
cd build | |||
``` | |||
|
|||
4. Before `gz-rendering` becomes available on conda-forge, we need to build it from source and specify the path containing `gz-rendering-config.cmake` in `CMAKE_PREFIX_PATH`, for cmake to find `gz-rendering`. That path could be `gz-rendering-install-path\lib\cmake\gz-rendering4`, for example. | |||
4. Before `gz-rendering` becomes available on conda-forge, we need to build it from source and specify the path containing `gz-rendering-config.cmake` in `CMAKE_PREFIX_PATH`, for cmake to find `gz-rendering`. That path could be `gz-rendering-install-path\lib\cmake\gz-rendering8`, for example. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mjcarroll the windows instructions are probably out of date? Is it possible to just do
conda install libgz-sensors<#>
/ conda install libgz-rendering<#>
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is correct:
https://prefix.dev/channels/conda-forge/packages/gz-sensors7
https://prefix.dev/channels/conda-forge/packages/gz-rendering7
The harmonic versions will come when we have official tags, according to @traversaro
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, conda-forge does not do prerelease in general, see https://conda-forge.org/docs/maintainer/knowledge_base.html#pre-release-builds .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated windows instructions in f975133
Codecov Report
@@ Coverage Diff @@
## gz-sensors8 #382 +/- ##
============================================
Coverage 72.76% 72.76%
============================================
Files 36 36
Lines 4968 4968
============================================
Hits 3615 3615
Misses 1353 1353 |
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
🦟 Bug fix
gazebosim/gazebo_test_cases#179
Summary
ign/ignition -> gz
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.