Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 7 -> 8 #387

Merged
merged 6 commits into from
Sep 27, 2023
Merged

Merge 7 -> 8 #387

merged 6 commits into from
Sep 27, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 26, 2023

➡️ Forward port

Port gz-sensors7 to gz-sensors8

Branch comparison: gz-sensors8...gz-sensors7

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

Levi-Armstrong and others added 6 commits July 21, 2023 10:16
* Fix CameraSensor to check if element is null before access

Signed-off-by: Levi Armstrong <levi.armstrong@gmail.com>
…ensor (#362)

Signed-off-by: Levi Armstrong <levi.armstrong@gmail.com>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #387 (d6fa933) into gz-sensors8 (cf62d0f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head d6fa933 differs from pull request most recent head 1caa53b. Consider uploading reports for the commit 1caa53b to get more accurate results

@@               Coverage Diff               @@
##           gz-sensors8     #387      +/-   ##
===============================================
+ Coverage        72.76%   72.78%   +0.02%     
===============================================
  Files               36       36              
  Lines             4968     4972       +4     
===============================================
+ Hits              3615     3619       +4     
  Misses            1353     1353              
Files Coverage Δ
src/CameraSensor.cc 76.31% <100.00%> (+0.17%) ⬆️
src/DepthCameraSensor.cc 74.90% <100.00%> (+0.09%) ⬆️

@azeey azeey added the beta Targeting beta release of upcoming collection label Sep 27, 2023
@azeey azeey merged commit f48aab8 into gz-sensors8 Sep 27, 2023
7 checks passed
@azeey azeey deleted the merge_7_8_20230926 branch September 27, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🎵 harmonic Gazebo Harmonic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants