Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing model with JointPositionController plugin leads to 'entity does not exist' error messages. #2165

Closed
jrutgeer opened this issue Sep 22, 2023 · 2 comments
Closed

Removing model with JointPositionController plugin leads to 'entity does not exist' error messages. #2165

jrutgeer opened this issue Sep 22, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@jrutgeer
Copy link
Contributor

When a model that uses the JointPositionController plugin is removed from the simulation through the UserCommands service, repeating error messages appear:

[Err] [EntityComponentManager.cc:1083] Trying to create a component of type [8319580315957903596] attached to entity [12], but this entity does not exist. This create component request will be ignored.

See the attached example files:

Run gz sim -r world.sdf
Spawn a model with the spawn script: ./spawn_boxes
Remove the boxes with the remove script: ./remove_boxes

--> The error messages start.

Edit the boxes.sdf file and remove the JointPositionController plugin.
Repeat the test.

--> No error messages after removal.

example.tar.gz
@jrutgeer jrutgeer added the bug Something isn't working label Sep 22, 2023
@arjo129
Copy link
Contributor

arjo129 commented Nov 6, 2023

I think if we solve #2217 this will no longer be an issue.

@jrutgeer
Copy link
Contributor Author

jrutgeer commented Nov 6, 2023

Closing as duplicate of #2217.

@jrutgeer jrutgeer closed this as completed Nov 6, 2023
arjo129 added a commit that referenced this issue Nov 7, 2023
@arjo129
Remove systems if their parent entity is removed
a7b1f22 
This commit tries to address #2217.

In particular if a user despawns an entity, the associated plugin gets
removed. This should prevent issues like #2165. TBH I'm not sure if this
is the right way forward as a system should technically be able to
access any entity in a traditional ECS. I also recognize that there may
be some performance impact. I will need to quantify this.

Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
@arjo129 arjo129 mentioned this issue Nov 7, 2023
Merged
8 tasks
jrutgeer added a commit to jrutgeer/gz-sim that referenced this issue Nov 21, 2023
@jrutgeer
Temporary fix for gazebosim#2165 until gazebosim#2217 is resolved.
a89796c 
Signed-off-by: Johan Rutgeerts <johan.rutgeerts@lancewood.eu>
@jrutgeer jrutgeer mentioned this issue Nov 21, 2023
Merged
arjo129 pushed a commit that referenced this issue Nov 22, 2023
@jrutgeer
Allow removal of model that has joint_position_controller plugin. (#2252
8b40b54 
)

* Temporary fix for #2165 until #2217 is resolved.

Signed-off-by: Johan Rutgeerts <johan.rutgeerts@lancewood.eu>

* Added comment to clarify the added code.

Signed-off-by: Johan Rutgeerts <johan.rutgeerts@lancewood.eu>

---------

Signed-off-by: Johan Rutgeerts <johan.rutgeerts@lancewood.eu>
arjo129 added a commit that referenced this issue Jul 9, 2024
@arjo129
Remove systems if their parent entity is removed
9b806c7 
This commit tries to address #2217.

In particular if a user despawns an entity, the associated plugin gets
removed. This should prevent issues like #2165. TBH I'm not sure if this
is the right way forward as a system should technically be able to
access any entity in a traditional ECS. I also recognize that there may
be some performance impact. I will need to quantify this.

Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
arjo129 added a commit that referenced this issue Jul 9, 2024
@arjo129
Remove systems if their parent entity is removed
33f47e8 
This commit tries to address #2217.

In particular if a user despawns an entity, the associated plugin gets
removed. This should prevent issues like #2165. TBH I'm not sure if this
is the right way forward as a system should technically be able to
access any entity in a traditional ECS. I also recognize that there may
be some performance impact. I will need to quantify this.

Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
Signed-off-by: Arjo Chakravarty <arjoc@google.com>
arjo129 added a commit that referenced this issue Jul 17, 2024
@arjo129
Remove systems if their parent entity is removed (#2232)
2994087 
n particular if a user despawns an entity, the associated plugin gets removed. This should prevent issues like #2165. TBH I'm not sure if this is the right way forward as a system should technically be able to access any entity in a traditional ECS.

The PR has now been reworked and greatly simplified. All we do is stop all worker threads if an entity is removed and then recreate remaining threads.
arjo129 added a commit that referenced this issue Jul 19, 2024
@arjo129
Remove systems if their parent entity is removed (#2232)
8da3ccd 
n particular if a user despawns an entity, the associated plugin gets removed. This should prevent issues like #2165. TBH I'm not sure if this is the right way forward as a system should technically be able to access any entity in a traditional ECS.

The PR has now been reworked and greatly simplified. All we do is stop all worker threads if an entity is removed and then recreate remaining threads.
arjo129 added a commit that referenced this issue Jul 22, 2024
@arjo129
Remove systems if their parent entity is removed (#2232)
d0c0322 
n particular if a user despawns an entity, the associated plugin gets removed. This should prevent issues like #2165. TBH I'm not sure if this is the right way forward as a system should technically be able to access any entity in a traditional ECS.

The PR has now been reworked and greatly simplified. All we do is stop all worker threads if an entity is removed and then recreate remaining threads.
arjo129 added a commit that referenced this issue Jul 26, 2024
@arjo129
Remove systems if their parent entity is removed (#2232)
793e5b7 
n particular if a user despawns an entity, the associated plugin gets removed. This should prevent issues like #2165. TBH I'm not sure if this is the right way forward as a system should technically be able to access any entity in a traditional ECS.

The PR has now been reworked and greatly simplified. All we do is stop all worker threads if an entity is removed and then recreate remaining threads.
arjo129 added a commit that referenced this issue Jul 26, 2024
@arjo129
Remove systems if their parent entity is removed (#2232)
ca4af94 
n particular if a user despawns an entity, the associated plugin gets removed. This should prevent issues like #2165. TBH I'm not sure if this is the right way forward as a system should technically be able to access any entity in a traditional ECS.

The PR has now been reworked and greatly simplified. All we do is stop all worker threads if an entity is removed and then recreate remaining threads.

Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
arjo129 added a commit that referenced this issue Jul 26, 2024
@arjo129
Remove systems if their parent entity is removed (#2232)
ba955aa 
n particular if a user despawns an entity, the associated plugin gets removed. This should prevent issues like #2165. TBH I'm not sure if this is the right way forward as a system should technically be able to access any entity in a traditional ECS.

The PR has now been reworked and greatly simplified. All we do is stop all worker threads if an entity is removed and then recreate remaining threads.

Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
iche033 pushed a commit that referenced this issue Aug 1, 2024
@arjo129 @iche033
Remove systems if their parent entity is removed (#2232)
55a0f55 
n particular if a user despawns an entity, the associated plugin gets removed. This should prevent issues like #2165. TBH I'm not sure if this is the right way forward as a system should technically be able to access any entity in a traditional ECS.

The PR has now been reworked and greatly simplified. All we do is stop all worker threads if an entity is removed and then recreate remaining threads.

Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
iche033 pushed a commit that referenced this issue Aug 2, 2024
@arjo129 @iche033
Remove systems if their parent entity is removed (#2232)
fb25971 
n particular if a user despawns an entity, the associated plugin gets removed. This should prevent issues like #2165. TBH I'm not sure if this is the right way forward as a system should technically be able to access any entity in a traditional ECS.

The PR has now been reworked and greatly simplified. All we do is stop all worker threads if an entity is removed and then recreate remaining threads.

Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Core development
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arjo129 @jrutgeer