Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MinimalScene by default #1014

Merged
merged 17 commits into from
Sep 22, 2021
Merged

Use MinimalScene by default #1014

merged 17 commits into from
Sep 22, 2021

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Sep 8, 2021

🎉 New feature

Part of gazebosim/gz-gui#137

Summary

Ideally we'd deprecate GzScene3D on Fortress so we stop maintaining 2 scenes. For that to happen, we need to achieve feature parity with MinimalScene. We need the following, and maybe more:

It would also be good to get this in, so it's easier to configure the GUI and users don't have to repeat lots of plugins for the 3D scene: Going without it for now

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added the GUI Gazebo's graphical interface (not pure Ignition GUI) label Sep 8, 2021
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Sep 8, 2021
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added the beta Targeting beta release of upcoming collection label Sep 8, 2021
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde force-pushed the chapulina/6/minimal_scene_def branch from 85d84a6 to e990ca9 Compare September 16, 2021 10:24
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde force-pushed the chapulina/6/minimal_scene_def branch from 9e675ab to 44ffff4 Compare September 21, 2021 11:14
@ahcorde ahcorde added the needs upstream release Blocked by a release of an upstream library label Sep 21, 2021
@ahcorde ahcorde marked this pull request as ready for review September 21, 2021 20:50
chapulina and others added 5 commits September 21, 2021 16:53
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label Sep 22, 2021
Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 with some minor nits

Migration.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #1014 (55d9790) into main (4be711c) will increase coverage by 0.13%.
The diff coverage is 27.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1014      +/-   ##
==========================================
+ Coverage   63.47%   63.60%   +0.13%     
==========================================
  Files         241      251      +10     
  Lines       19577    19614      +37     
==========================================
+ Hits        12426    12476      +50     
+ Misses       7151     7138      -13     
Impacted Files Coverage Δ
src/gui/plugins/spawn/Spawn.hh 100.00% <ø> (ø)
src/gui/plugins/spawn/Spawn.cc 10.30% <6.38%> (ø)
...ins/entity_context_menu/EntityContextMenuPlugin.cc 41.17% <41.17%> (ø)
...ins/entity_context_menu/EntityContextMenuPlugin.hh 100.00% <100.00%> (ø)
src/rendering/RenderUtil.cc 35.86% <0.00%> (-0.64%) ⬇️
src/ign.cc 71.89% <0.00%> (-0.48%) ⬇️
.../gui/plugins/transform_control/TransformControl.cc 6.97% <0.00%> (-0.26%) ⬇️
include/ignition/gazebo/gui/GuiEvents.hh 0.00% <0.00%> (ø)
src/gui/plugins/scene3d/Scene3D.hh
src/gui/plugins/scene_manager/GzSceneManager.hh 100.00% <0.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4be711c...55d9790. Read the comment docs.

Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
@chapulina chapulina merged commit 2c2605f into main Sep 22, 2021
@chapulina chapulina deleted the chapulina/6/minimal_scene_def branch September 22, 2021 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🏯 fortress Ignition Fortress GUI Gazebo's graphical interface (not pure Ignition GUI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants