-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preparing for 5.2.0 release #1139
Conversation
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo5 #1139 +/- ##
============================================
Coverage 66.34% 66.34%
============================================
Files 248 248
Lines 18981 18981
============================================
Hits 12593 12593
Misses 6388 6388 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few changelog entries point to old pull requests so they stood out to me. It looks like they have already been released in ignition-gazebo 5.1.0. Looking at ignition-gazebo5_5.1.0...ign-gazebo5, the commits (and PRs) on July 23, 2021 may have all been released. There could be more.
The problem could be due to backports from 4 -> 3 in #929. All those changes were then forward ported from 3 -> 4 -> 5. The changelog script then picks up that they are new changes in 5.2
Signed-off-by: Nate Koenig <nate@openrobotics.org>
I see. I've removed a number of instance from #929. |
I see this box wasn't checked. We should be mindful of dependency bumps and upgrade the debian metadata before triggering releases. Looking at the diff linked on the PR description: I see a few dependency bumps:
The release was triggered without these bumps, I still see old versions here: https://github.com/ignition-release/ign-gazebo5-release/blob/main/ubuntu/debian/control Which means that users that install |
* Preparing for 5.2.0 release Signed-off-by: Nate Koenig <nate@openrobotics.org> * Removed duplicate changes Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
Signed-off-by: Nate Koenig nate@openrobotics.org
🎈 Release
Preparation for 5.2.0 release.
Comparison to 5.2.0: ignition-gazebo5_5.1.0...ign-gazebo5
Checklist
Note to maintainers: Remember to use Squash-Merge