Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing for 5.2.0 release #1139

Merged
merged 2 commits into from
Oct 25, 2021
Merged

Preparing for 5.2.0 release #1139

merged 2 commits into from
Oct 25, 2021

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Oct 22, 2021

Signed-off-by: Nate Koenig nate@openrobotics.org

🎈 Release

Preparation for 5.2.0 release.

Comparison to 5.2.0: ignition-gazebo5_5.1.0...ign-gazebo5

Checklist

  • Asked team if this is a good time for a release
  • There are no changes to be ported from the previous major version
  • No PRs targeted at this major version are close to getting in
  • Bumped minor for new features, patch for bug fixes
  • Updated changelog
  • Updated migration guide (as needed)
  • Link to PR updating dependency versions in appropriate repository in ignition-release (as needed):

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Nate Koenig <nate@openrobotics.org>
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Oct 22, 2021
@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #1139 (479aa3d) into ign-gazebo5 (6fee412) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gazebo5    #1139   +/-   ##
============================================
  Coverage        66.34%   66.34%           
============================================
  Files              248      248           
  Lines            18981    18981           
============================================
  Hits             12593    12593           
  Misses            6388     6388           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fee412...479aa3d. Read the comment docs.

Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few changelog entries point to old pull requests so they stood out to me. It looks like they have already been released in ignition-gazebo 5.1.0. Looking at ignition-gazebo5_5.1.0...ign-gazebo5, the commits (and PRs) on July 23, 2021 may have all been released. There could be more.

The problem could be due to backports from 4 -> 3 in #929. All those changes were then forward ported from 3 -> 4 -> 5. The changelog script then picks up that they are new changes in 5.2

Changelog.md Outdated Show resolved Hide resolved
Changelog.md Outdated Show resolved Hide resolved
Changelog.md Outdated Show resolved Hide resolved
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig
Copy link
Contributor Author

nkoenig commented Oct 25, 2021

a few changelog entries point to old pull requests so they stood out to me. It looks like they have already been released in ignition-gazebo 5.1.0. Looking at ignition-gazebo5_5.1.0...ign-gazebo5, the commits (and PRs) on July 23, 2021 may have all been released. There could be more.

The problem could be due to backports from 4 -> 3 in #929. All those changes were then forward ported from 3 -> 4 -> 5. The changelog script then picks up that they are new changes in 5.2

I see. I've removed a number of instance from #929.

@nkoenig nkoenig merged commit 0d520e7 into ign-gazebo5 Oct 25, 2021
@nkoenig nkoenig deleted the 5-2-0-prep branch October 25, 2021 16:56
@chapulina
Copy link
Contributor

Link to PR updating dependency versions in appropriate repository in ignition-release (as needed):

I see this box wasn't checked. We should be mindful of dependency bumps and upgrade the debian metadata before triggering releases.

Looking at the diff linked on the PR description:

ignition-gazebo5_5.1.0...ign-gazebo5#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a

I see a few dependency bumps:

  • ign-common 4.2
  • ign-gui 5.2
  • ign-physics added the heightmap component (not sure if this needs a change in the metadata)

The release was triggered without these bumps, I still see old versions here:

https://github.com/ignition-release/ign-gazebo5-release/blob/main/ubuntu/debian/control

Which means that users that install ign-gazebo 5.2 without upgrading dependencies will have runtime issues.

WilliamLewww pushed a commit to WilliamLewww/ign-gazebo that referenced this pull request Dec 7, 2021
* Preparing for 5.2.0 release

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* Removed duplicate changes

Signed-off-by: Nate Koenig <nate@openrobotics.org>

Co-authored-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants