Add multichannel lookup for environment sensors. #1814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some data such as ocean currents or wind speed take on vector values. This PR adds support for such types of data. Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Often when sensing we may be interested in vector quantities. This PR extends the environmental_sensor to support vector quantities. Some additional work was required handle transformations. In particular if the data is something like Ocean Currents or Wind then the data has to be transformed to the robot's local coordinate frame and the robot's velocity also has to be accounted for. Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
arjo129
added
the
MBARI-LRAUV
arjo129
changed the title
Codecov Report
@@ Coverage Diff @@
## gz-sim7 #1814 +/- ##
===========================================
+ Coverage 64.37% 64.64% +0.26%
===========================================
Files 341 342 +1
Lines 27132 27383 +251
===========================================
+ Hits 17467 17701 +234
- Misses 9665 9682 +17
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
hidmic
reviewed
Dec 1, 2022
src/systems/environmental_sensor_system/EnvironmentalSensorSystem.cc
Outdated
Show resolved
Hide resolved
src/systems/environmental_sensor_system/EnvironmentalSensorSystem.cc
Outdated
Show resolved
Hide resolved
src/systems/environmental_sensor_system/EnvironmentalSensorSystem.hh
Outdated
Show resolved
Hide resolved
src/systems/environmental_sensor_system/EnvironmentalSensorSystem.cc
Outdated
Show resolved
Hide resolved
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
hidmic
reviewed
Dec 15, 2022
src/systems/environmental_sensor_system/EnvironmentalSensorSystem.cc
Outdated
Show resolved
Hide resolved
src/systems/environmental_sensor_system/EnvironmentalSensorSystem.cc
Outdated
Show resolved
Hide resolved
src/systems/environmental_sensor_system/EnvironmentalSensorSystem.cc
Outdated
Show resolved
Hide resolved
| break; | ||
| default: | ||
| result = (_reading + offset); | ||
| } |
There was a problem hiding this comment.
@arjo129 meta: it would almost seem like local/global is orthogonal to whether velocity should be computed relative some observer or the world? Would it make sense to split them?
There was a problem hiding this comment.
Thats true, but in the interest of time we can check this in.
| // Create a vehicle rotated 90 degrees in the yaw axis | ||
| math::Pose3d pose(math::Vector3d(0, 0, 0), math::Quaterniond(0, 0, GZ_PI_2)); | ||
|
|
||
| // Vehicle should moving at 1m/s along x-axis (In global frame) |
There was a problem hiding this comment.
@arjo129 nit:
Suggested change
| // Vehicle should moving at 1m/s along x-axis (In global frame) | |
| // Vehicle should be moving at 1m/s along x-axis (In global frame) |
| // Vehicle should moving at 1m/s along x-axis (In global frame) | ||
| math::Vector3d velocity(1, 0, 0); | ||
|
|
||
| // Imagine a current moving against the vehicle |
There was a problem hiding this comment.
@arjo129 imagine is an interesting choice of words.
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸
🎉 New feature
Closes #
Summary
Often when sensing we may be interested in vector quantities. This PR extends the environmental_sensor to support vector quantities. Some additional work was required handle transformations. In particular if the data is something like Ocean Currents or Wind then the data has to be transformed to the robot's local coordinate frame and the robot's velocity also has to be accounted for.
Test it
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.