Disable tests that require dartsim on windows #1840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dartsim component of gz-physics is currently not built on CI, so these tests should be disabled. Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo6 #1840 +/- ##
===============================================
+ Coverage 64.73% 64.75% +0.02%
===============================================
Files 321 321
Lines 26313 26313
===============================================
+ Hits 17034 17040 +6
+ Misses 9279 9273 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
iche033
approved these changes
Dec 16, 2022
Yeah, the comparisons are against each other, not against an expected velocity. I still think we should disable it though since it would be giving a false impression if it passes without physics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dartsim component of gz-physics is currently not built on CI, so these tests should be disabled.