Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header guard fix for battery power load component #1846

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

marcoag
Copy link
Member

@marcoag marcoag commented Dec 22, 2022

Signed-off-by: Marco A. Gutierrez marco@openrobotics.org

🦟 Bug fix

Related to #1811.

Summary

Fix to the header guard for the battery power load component where the #ifndef was not matching the following #define.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Dec 22, 2022
@marcoag marcoag requested a review from azeey December 22, 2022 00:39
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #1846 (58da7f0) into ign-gazebo6 (10ed22b) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 58da7f0 differs from pull request most recent head b94683b. Consider uploading reports for the commit b94683b to get more accurate results

@@               Coverage Diff               @@
##           ign-gazebo6    #1846      +/-   ##
===============================================
- Coverage        64.80%   64.75%   -0.05%     
===============================================
  Files              322      322              
  Lines            26389    26389              
===============================================
- Hits             17102    17089      -13     
- Misses            9287     9300      +13     
Impacted Files Coverage Δ
...ude/ignition/gazebo/components/BatteryPowerLoad.hh 100.00% <ø> (ø)
src/SimulationRunner.cc 89.87% <0.00%> (-1.90%) ⬇️
src/EntityComponentManager.cc 89.38% <0.00%> (-0.13%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@azeey
Copy link
Contributor

azeey commented Dec 22, 2022

I don't know how a PR that fixes a header guard could change overage at all. I wonder if our coverage tool isn't working properly.

image

@marcoag
Copy link
Member Author

marcoag commented Dec 22, 2022

It seems like the code in this component could have not been taken into account...

@marcoag marcoag merged commit 68008d2 into ign-gazebo6 Dec 22, 2022
@marcoag marcoag deleted the marcoag/fix_battery_macos_warning branch December 22, 2022 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants