Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed a code block in the python interfaces tutorial #1982

Merged
merged 1 commit into from
May 2, 2023
Merged

fixed a code block in the python interfaces tutorial #1982

merged 1 commit into from
May 2, 2023

Conversation

mplemay
Copy link
Contributor

@mplemay mplemay commented May 2, 2023

Summary

Fixed a minor error in the python tutorial.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@mplemay mplemay requested a review from mabelzhang as a code owner May 2, 2023 17:23
@github-actions github-actions bot added the 🌱 garden Ignition Garden label May 2, 2023
@azeey
Copy link
Contributor

azeey commented May 2, 2023

Thanks for the contribution! Mind signing off on your commit per https://gazebosim.org/docs/all/contributing#contributing-code?

@mplemay
Copy link
Contributor Author

mplemay commented May 2, 2023

Thanks for the contribution! Mind signing off on your commit per https://gazebosim.org/docs/all/contributing#contributing-code?

Done

Signed-off-by: Matthew LeMay <mplemay@users.noreply.github.com>
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #1982 (05edf8a) into gz-sim7 (5d359c6) will increase coverage by 0.12%.
The diff coverage is n/a.

❗ Current head 05edf8a differs from pull request most recent head 92ae9ce. Consider uploading reports for the commit 92ae9ce to get more accurate results

@@             Coverage Diff             @@
##           gz-sim7    #1982      +/-   ##
===========================================
+ Coverage    64.88%   65.01%   +0.12%     
===========================================
  Files          352      352              
  Lines        28429    28429              
===========================================
+ Hits         18447    18483      +36     
+ Misses        9982     9946      -36     

see 4 files with indirect coverage changes

@mjcarroll mjcarroll merged commit a18e217 into gazebosim:gz-sim7 May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants