-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop python3-distutils from Noble package list (onwards) #2374
Conversation
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
AFAIK, the only place we need it is in Lines 9 to 14 in dc3fb11
|
attempting to drop it from gz-math8 in gazebosim/gz-math#587 |
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
You are right, aebfe55 |
Don't need it anymore Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
python/CMakeLists.txt
Outdated
# Python3_SITEARCH is available from 3.12 on, workaround if needed: | ||
find_package(Python3 COMPONENTS Interpreter) | ||
endif() | ||
find_package(Python3 COMPONENTS Interpreter) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can leave the code as is. It's technically possible for someone to build this with cmake 3.10. But we know for sure our CI will have a newer version of cmake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverted
This reverts commit aebfe55. Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
1d9e211
to
7918121
Compare
.github/ci/packages-jammy.apt
Outdated
@@ -0,0 +1 @@ | |||
python3-distutils |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you opposed to removing python3-distutils
from any of the .apt
files? I think it would be fine since Jammy has a newer version of cmake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be fine to remove for Harmonic since 22.04 has cmake 3.22.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. Sorry did not see the whole picture before. Removed.
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
🎉 New feature
Summary
There is no
python3-distutils
package anymore in Ubuntu starting with Noble. Drop it and keep a copy of current packages for Jammy.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.