Update sensors with pending trigger immediately in Sensors system #2408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shameek Ganguly <shameekarcanesphinx@gmail.com>
shameekganguly
added
the
needs upstream release
7 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## gz-sim8 #2408 +/- ##
===========================================
+ Coverage 64.88% 65.92% +1.03%
===========================================
Files 360 327 -33
Lines 29448 31328 +1880
===========================================
+ Hits 19108 20653 +1545
- Misses 10340 10675 +335 ☔ View full report in Codecov by Sentry. |
iche033
approved these changes
May 28, 2024
iche033
removed
the
needs upstream release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes gazebosim/gz-sensors#426
Summary
Update Sensors system to ignore update rate for sensors that have pending triggers and update them immediately. Depends on upstream gazebosim/gz-sensors#431.
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.