Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove <gz:system_priority/> from test worlds #2551

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Remove <gz:system_priority/> from test worlds #2551

merged 2 commits into from
Aug 27, 2024

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Follow-up to #2494 and #2500.

Summary

The system priority for the force-torque system was explicitly set using XML tags in several test worlds in #2494. These XML tags are no longer needed since #2500 was merged, so remove them now.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@scpeters
Remove <gz:system_priority/> from test worlds
28acf1f 
The system priority for the force-torque system was
explicitly set using XML tags in several test worlds
in #2494. These XML tags are no longer needed since #2500
was merged, so remove them now.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Aug 27, 2024
@scpeters
Fix outdated comments
d4bc17d 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters requested a review from azeey as a code owner August 27, 2024 21:22
@scpeters scpeters merged commit af7fabb into main Aug 27, 2024
8 of 9 checks passed
@scpeters scpeters deleted the scpeters/revert_ft_xml_priority_changes branch August 27, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iche033 iche033 iche033 approved these changes

@mjcarroll mjcarroll Awaiting requested review from mjcarroll mjcarroll is a code owner

@azeey azeey Awaiting requested review from azeey azeey is a code owner

Assignees
No one assigned
Labels
🏛️ ionic Gazebo Ionic
Projects
Core development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scpeters @iche033