Fix xml and image in create maritime vehicle tutorial #2583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The angular velocity was calculated using euler angles which led to singularities --------- Signed-off-by: Tom Creutz <tcreutz97@gmail.com> Signed-off-by: Shameek Ganguly <shameek@google.com> Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org> Co-authored-by: Aditya Pande <aditya050995@gmail.com> Co-authored-by: Ian Chen <ichen@openrobotics.org> Co-authored-by: Shameek Ganguly <shameek@google.com>
Added a check for non-empty laser scan ranges before accessing the elements. Signed-off-by: Ian Chen <ichen@openrobotics.org>
* check !empty(), not compare to size() * include what you use: add missing, remove unused headers, alphabetize. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
* Model.hh: add ModelByName and ModelCount APIs Backport nested model accessor APIs from #2494. * Add WrenchMeasured component * Physics.cc: fix typo in comment * sensor_TEST.py: move PreUpdate callback to Update The test's PreUpdate callback assumes that it executes after the ForceTorque::PreUpdate, so just move it to Update to gurantee it. Also fix a spelling error in the callback variable names. * fix spelling in on_post_update_cb * backport minor fixes to force-torque test * Include System.hh from some systems, add comment Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Azmyin M. Kamal <azmyin12@gmail.com>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
|
@alexandrosnic can you sign off DCO please. |
|
also, do you mind targeting the |
Signed-off-by: Alexandros Nikolaou <alexnic31@gmail.com>
alexandrosnic
force-pushed
the
fix-create-maritime-vehicle
branch
from
91d8dc9
to
2d7547d
Compare
Signed-off-by: Alexandros Nicolaou <34197007+alexandrosnic@users.noreply.github.com>
|
@azeey @mjcarroll sorry for the mess, but just to not mess up with commits and rebase, I created a new PR #2592 with the correct branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #
Summary
Replaced single quotes '' to double quotes "" in xml (my xml parser did not accept the single quotes), and fixed the path to the image in order to be displayed.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.