-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Joint Tutorial needs topic_name in SDF examples. #2629
base: gz-sim9
Are you sure you want to change the base?
Conversation
Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
<position_i_max>1</position_i_max> | ||
<position_cmd_min>-20</position_cmd_min> | ||
<position_cmd_max>20</position_cmd_max> | ||
<topic>topic_name</topic> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So what's the behavior without <topic>
specified? Can we make sure that scenario works as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure you would need to pass it to the default topic instead. Is that preferred? Or just want it duplicated in that portion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess my question is, has the default topic changed? I ask because #2546 changed some default topics for some systems and those systems had to be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the default topic I don't believe has changed, the tutorial shows to publish this to control it:
gz-sim/tutorials/joint_controller.md
Line 622 in 76305df
gz topic -t "topic_name" -m gz.msgs.JointTrajectory -p ' |
Note that you need to have the topic name match that topic or it won't work.
And then it says to echo:
gz-sim/tutorials/joint_controller.md
Line 670 in 76305df
gz topic -e -t "/model/RR_position_control/joint_trajectory_progress" |
Which once again if you change it to listen to published topic won't work. So one or the other needs to be changed/fixed to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So @azeey do you want an example with only the default topic, only the "assigned topic" or one with both?
π¦ Bug fix
Summary
This is my bad on not pushing up the final commit on adding
topic_name
in a few places so that the trajectory control portion works properly. π€¦π»ββοΈThis also fixes the indents so they match when copying and pasting through tutorial.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.