apply_joint_force: Simplified using ComponentDefault #2630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Pecka <peci1@seznam.cz>
azeey
requested changes
Sep 16, 2024
| @@ -156,23 +156,14 @@ void ApplyJointForce::PreUpdate(const UpdateInfo &_info, | |||
|
|
|||
| // Update joint force | |||
| //! [jointForceComponent] | |||
| auto force = _ecm.Component<components::JointForceCmd>( | |||
| this->dataPtr->jointEntity); | |||
| auto force = _ecm.ComponentDefault<components::JointForceCmd>( | |||
There was a problem hiding this comment.
I'd rather not make this kind of change in a code freeze. We can merge this after Ionic is released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
ComponentDefault has been added quite some time ago. I've noticed the JointForceCmd component tutorial still uses the cumbersome
if (component == null) CreateComponent()approach.This PR modernizes it to use
ComponentDefaultand modernizes the accompanying tutorial as well.I've compile- and run-tested this change and it seems everything works as it should.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.