Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Video recorder plugin work with MinimalScene #900

Merged
merged 15 commits into from
Sep 22, 2021
Merged

Make Video recorder plugin work with MinimalScene #900

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
3a7d09c
Add scene manager GUI plugin that works with ign-gui's Scene3D
chapulina May 12, 2021
80161fb
cleanup
chapulina May 12, 2021
d0d7066
Merge branch 'main' into chapulina/6/scene_manager
chapulina Jun 19, 2021
5f94fe2
Update to latest
chapulina Jun 21, 2021
c5b16d2
Merge branch 'main' into chapulina/6/scene_manager
chapulina Jun 24, 2021
53ce2f2
Added Video recorder plugin
ahcorde Jul 2, 2021
514d329
Select the user camera with UserData method
ahcorde Jul 2, 2021
ce3f505
make linters happy
ahcorde Jul 2, 2021
3671b7e
Merge remote-tracking branch 'origin/main' into ahcorde/plugin/video_…
ahcorde Aug 12, 2021
7650dda
Move video recording logic to existing plugin and add legacy mode
chapulina Aug 13, 2021
f895be4
Merge branch 'main' into ahcorde/plugin/video_recorder_logic
ahcorde Aug 16, 2021
1dc3ac9
Merge branch 'main' into ahcorde/plugin/video_recorder_logic
chapulina Aug 17, 2021
a6771bf
Added feedback
ahcorde Sep 21, 2021
2aeb86f
merged from main
chapulina Sep 21, 2021
ab58eee
remove unused code
chapulina Sep 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 26 additions & 7 deletions examples/worlds/minimal_scene.sdf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ Features:
* Markers
* Tape measure
* Grid config
* Video recording
* Select entities
* Transform controls

Expand Down Expand Up @@ -131,8 +132,6 @@ Missing for parity with GzScene3D:
<play_pause>true</play_pause>
<step>true</step>
<start_paused>true</start_paused>
<service>/world/buoyancy/control</service>
<stats_topic>/world/buoyancy/stats</stats_topic>

</plugin>

Expand All @@ -157,7 +156,6 @@ Missing for parity with GzScene3D:
<real_time>true</real_time>
<real_time_factor>true</real_time_factor>
<iterations>true</iterations>
<topic>/world/buoyancy/stats</topic>
</plugin>

<!-- Insert simple shapes -->
Expand Down Expand Up @@ -219,19 +217,40 @@ Missing for parity with GzScene3D:
</ignition-gui>
</plugin>

<!-- Video recorder -->
<plugin filename="VideoRecorder" name="VideoRecorder">
<ignition-gui>
<property key="resizable" type="bool">false</property>
<property key="x" type="double">300</property>
<property key="y" type="double">50</property>
<property key="width" type="double">50</property>
<property key="height" type="double">50</property>
<property key="state" type="string">floating</property>
<property key="showTitleBar" type="bool">false</property>
<property key="cardBackground" type="string">#777777</property>
</ignition-gui>

<record_video>
<use_sim_time>true</use_sim_time>
<lockstep>true</lockstep>
<bitrate>4000000</bitrate>
</record_video>

<!-- disable legacy features used to connect this plugin to GzScene3D -->
<legacy>false</legacy>
</plugin>

<!-- Inspector -->
<plugin filename="ComponentInspector" name="Component inspector">
<ignition-gui>
<property type="bool" key="showTitleBar">false</property>
<property type="string" key="state">docked</property>
<property type="string" key="state">docked_collapsed</property>
</ignition-gui>
</plugin>

<!-- Entity tree -->
<plugin filename="EntityTree" name="Entity tree">
<ignition-gui>
<property type="bool" key="showTitleBar">false</property>
<property type="string" key="state">docked</property>
<property type="string" key="state">docked_collapsed</property>
</ignition-gui>
</plugin>

Expand Down
8 changes: 6 additions & 2 deletions src/gui/plugins/video_recorder/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
gz_add_gui_plugin(VideoRecorder
SOURCES VideoRecorder.cc
QT_HEADERS VideoRecorder.hh
SOURCES
VideoRecorder.cc
QT_HEADERS
VideoRecorder.hh
PUBLIC_LINK_LIBS
ignition-rendering${IGN_RENDERING_VER}::ignition-rendering${IGN_RENDERING_VER}
)
Loading