Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not overwrite default linker flags so that LDFLAGS environment variable is considered #35

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

traversaro
Copy link
Contributor

This fix is similar to gazebosim/gazebo-classic#2922, but in this case the problem also affected the CXXFLAGS variable.

@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Jan 22, 2021
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind signing DCO, @traversaro ? Thanks!

…iable is considered

Signed-off-by: Silvio Traversaro <silvio.traversaro@iit.it>
@traversaro
Copy link
Contributor Author

Mind signing DCO, @traversaro ? Thanks!

Sure (I always forget). Done!

@chapulina chapulina merged commit b9dacc2 into gazebosim:ign-tools1 Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants