Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump cmake to 2.8.12 #85

Merged
merged 1 commit into from
Apr 22, 2022
Merged

bump cmake to 2.8.12 #85

merged 1 commit into from
Apr 22, 2022

Conversation

ijnek
Copy link
Contributor

@ijnek ijnek commented Apr 18, 2022

🦟 Bug fix

Bug

Deprecation warning when building with CMake >3.19.1:

--- stderr: ignition-tools
  CMake Deprecation Warning at CMakeLists.txt:2 (cmake_minimum_required):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.
---

Summary

Prevents a deprecation warning that arises since CMake3.19.1:
Similar PR has been raised and merged in facebook/zstd#2399.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
@ijnek ijnek requested a review from caguero as a code owner April 18, 2022 08:15
@github-actions github-actions bot added 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Apr 18, 2022
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that should be good on all our supported platforms.

@chapulina chapulina merged commit cf35e42 into gazebosim:ign-tools1 Apr 22, 2022
@ijnek ijnek deleted the bump-cmake-to-2.8.12 branch April 22, 2022 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants