Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ign-transport8] Update BitBucket links #124

Merged
merged 6 commits into from
Apr 22, 2020

Conversation

chapulina
Copy link
Contributor

Signed-off-by: Louise Poubel louise@openrobotics.org

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@@ -22,16 +22,16 @@ cd ~/ign_transport_tutorial/docker

We'll use Docker to configure the environment for this example. Feel free to
install Docker following any of the existing guides available
([here](https://bitbucket.org/osrf/vrx/wiki/tutorials/installDocker)'s one).
([here](https://github.com/osrf/vrx/wiki/tutorials/installDocker)'s one).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chapulina can't find a link to replace this dead one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't ported VRX to GitHub yet, but my suggestion would be to point to an official Docker tutorial instead

tutorials/07_relay.md Outdated Show resolved Hide resolved
maryaB-osr
maryaB-osr previously approved these changes Apr 22, 2020
Copy link
Contributor

@maryaB-osr maryaB-osr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions

@maryaB-osr maryaB-osr dismissed their stale review April 22, 2020 14:36

should fix those links first

Copy link
Contributor

@maryaB-osr maryaB-osr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix two links

tutorials/07_relay.md Outdated Show resolved Hide resolved
@maryaB-osr maryaB-osr merged commit 185edc9 into ign-transport8 Apr 22, 2020
@maryaB-osr maryaB-osr deleted the github_changelog_ign-transport8 branch April 22, 2020 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants