Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tools/code_check and update codecov #246

Merged
merged 1 commit into from
May 13, 2021

Conversation

chapulina
Copy link
Contributor

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from caguero as a code owner May 12, 2021 22:20
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label May 12, 2021
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #246 (a5cb1de) into ign-transport8 (2bbb2af) will increase coverage by 0.35%.
The diff coverage is 89.83%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           ign-transport8     #246      +/-   ##
==================================================
+ Coverage           83.41%   83.76%   +0.35%     
==================================================
  Files                  49       51       +2     
  Lines                4920     5033     +113     
==================================================
+ Hits                 4104     4216     +112     
- Misses                816      817       +1     
Impacted Files Coverage Δ
log/src/Descriptor.cc 89.65% <ø> (ø)
log/src/cmd/LogCommandAPI.cc 62.50% <ø> (ø)
src/NodePrivate.hh 100.00% <ø> (ø)
src/NodeSharedPrivate.hh 100.00% <ø> (ø)
src/TopicStatistics.cc 88.52% <88.52%> (ø)
src/NodeShared.cc 78.89% <90.62%> (+0.94%) ⬆️
src/Node.cc 92.34% <92.59%> (-0.01%) ⬇️
include/ignition/transport/Discovery.hh 87.73% <100.00%> (+0.02%) ⬆️
include/ignition/transport/TopicStatistics.hh 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8a31da...a5cb1de. Read the comment docs.

@chapulina chapulina merged commit 5d88091 into ign-transport8 May 13, 2021
@chapulina chapulina deleted the chapulina/codecheck branch May 13, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants