Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in help message in topic_main.cc #292

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

adityapande-1995
Copy link
Contributor

@adityapande-1995 adityapande-1995 commented Mar 2, 2022

Signed-off-by: Aditya aditya050995@gmail.com

🦟 Bug fix

Summary

This PR fixes a minor typo in the help message displayed by the command ign topic.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Aditya <aditya050995@gmail.com>
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Mar 2, 2022
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #292 (8543586) into ign-transport11 (e02bd8b) will not change coverage.
The diff coverage is n/a.

❗ Current head 8543586 differs from pull request most recent head 8d386a4. Consider uploading reports for the commit 8d386a4 to get more accurate results

Impacted file tree graph

@@               Coverage Diff                @@
##           ign-transport11     #292   +/-   ##
================================================
  Coverage            89.06%   89.06%           
================================================
  Files                   51       51           
  Lines                 4772     4772           
================================================
  Hits                  4250     4250           
  Misses                 522      522           
Impacted Files Coverage Δ
src/cmd/topic_main.cc 96.49% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e02bd8b...8d386a4. Read the comment docs.

@ahcorde ahcorde merged commit 3386680 into ign-transport11 Mar 2, 2022
@ahcorde ahcorde deleted the aditya/topic_main_cc_typo branch March 2, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants