Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parameters component #305

Merged
merged 60 commits into from
Oct 26, 2022
Merged

Add parameters component #305

merged 60 commits into from
Oct 26, 2022

Commits on May 24, 2022

  1. wip 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed May 24, 2022
    Configuration menu
    Copy the full SHA
    3d691a7 View commit details
    Browse the repository at this point in the history

  2. wip 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed May 24, 2022
    Configuration menu
    Copy the full SHA
    493af65 View commit details
    Browse the repository at this point in the history

  3. wip 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed May 24, 2022
    Configuration menu
    Copy the full SHA
    2573250 View commit details
    Browse the repository at this point in the history

  4. Complete implementation of parameters::Registry class 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed May 24, 2022
    Configuration menu
    Copy the full SHA
    c0b587f View commit details
    Browse the repository at this point in the history

  5. Use const std::string & when appropriate 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed May 24, 2022
    Configuration menu
    Copy the full SHA
    c7e67ac View commit details
    Browse the repository at this point in the history

  6. First ParameterClient implementation 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed May 24, 2022
    Configuration menu
    Copy the full SHA
    d3d0a09 View commit details
    Browse the repository at this point in the history

  7. Add ListParameters() to both registry and client 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed May 24, 2022
    Configuration menu
    Copy the full SHA
    1878dbb View commit details
    Browse the repository at this point in the history

  8. Fix 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed May 24, 2022
    Configuration menu
    Copy the full SHA
    5b8cf84 View commit details
    Browse the repository at this point in the history

  9. Fix declare parameter 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed May 24, 2022
    Configuration menu
    Copy the full SHA
    8490314 View commit details
    Browse the repository at this point in the history

  10. Add command line API for param 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed May 24, 2022
    Configuration menu
    Copy the full SHA
    e47860c View commit details
    Browse the repository at this point in the history

  11. Document ParameterRegistry class 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed May 24, 2022
    Configuration menu
    Copy the full SHA
    c201493 View commit details
    Browse the repository at this point in the history

  12. fix code style 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed May 24, 2022
    Configuration menu
    Copy the full SHA
    a96f102 View commit details
    Browse the repository at this point in the history

  13. Make methods const when possible. Fix logs 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed May 24, 2022
    Configuration menu
    Copy the full SHA
    832a8ab View commit details
    Browse the repository at this point in the history

  14. Make mehtods const if possible, alphabetize includes 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed May 24, 2022
    Configuration menu
    Copy the full SHA
    e45478a View commit details
    Browse the repository at this point in the history

  15. Remove copy-pasted line in docs 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed May 24, 2022
    Configuration menu
    Copy the full SHA
    d0e64ce View commit details
    Browse the repository at this point in the history

  16. * Use pimpl in ParametersClient. 

    * Document ParametersClient.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed May 24, 2022
    Configuration menu
    Copy the full SHA
    8ef1fce View commit details
    Browse the repository at this point in the history

  17. rename GetParameter() to Parameter() 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed May 24, 2022
    Configuration menu
    Copy the full SHA
    b004c95 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2022

  1. Add unit tests for ParametersRegistry and fixes 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    0518eb4 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2022

  1. Fix style issues in Registry_TEST.cc 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    97d8e8d View commit details
    Browse the repository at this point in the history

  2. Add unit tests for parameters client 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    b7508f4 View commit details
    Browse the repository at this point in the history

  3. Fix bug in DeclareParameter service callback 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    22290ac View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2022

  1. Merge branch 'ign-transport11' into ivanpauno/parameters-component11

    @caguero
    caguero committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    6b721ce View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2022

  1. Add a ParamtersInterface base class, make ParametersClient a derived … 

    …class of it

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    418ec77 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2022

  1. Derive ParametersRegistry from ParametersInterface 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    c36144a View commit details
    Browse the repository at this point in the history

  2. Make lints pass 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    cf11a3e View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2022

  1. Adapt code to use google::protobuf::Any 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    32ea9a1 View commit details
    Browse the repository at this point in the history

  2. Communicate errors in SetParameter/DeclareParameter correctly between… 

    … server and client

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    f624a9d View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/ivanpauno/parameters-component11… 

    …' into ivanpauno/parameters-component11
    @ivanpauno
    ivanpauno committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    8b7e18b View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2022

  1. Merge branch 'ign-transport11' into ivanpauno/parameters-component11

    @caguero
    caguero committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    3fb61c2 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2022

  1. Merge branch 'ign-transport11' into ivanpauno/parameters-component11

    @scpeters
    scpeters committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    2973504 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2022

  1. Replace NO_ERROR with SUCCESS 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    a1586e1 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2022

  1. Add visibility macros 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    21911ce View commit details
    Browse the repository at this point in the history

  2. codecheck 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    f93da8f View commit details
    Browse the repository at this point in the history

  3. Maybe fix build error on Windows 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    6c1007b View commit details
    Browse the repository at this point in the history

  4. Fix build warning on windows 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    4089abf View commit details
    Browse the repository at this point in the history

  5. Fix comment 

    Signed-off-by: Steve Peters <scpeters@openrobotics.org>
    @scpeters
    scpeters committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    1688b63 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2022

  1. Remove unnecessary cmake warning 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    2ea957d View commit details
    Browse the repository at this point in the history

  2. Add function separators 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    ccb520f View commit details
    Browse the repository at this point in the history

  3. Use camelCase for free functions 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    dff201b View commit details
    Browse the repository at this point in the history

  4. Add unit tests for parameters utils module 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    8adc376 View commit details
    Browse the repository at this point in the history

  5. Fix linking on Windows 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    b4bb900 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2022

  1. Add tests for ParamCommandAPI 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    d5c7c0c View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2022

  1. Please cpplint 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    dc77e1d View commit details
    Browse the repository at this point in the history

  2. Mark symbols in ParamCommandAPI as visible 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    34f6190 View commit details
    Browse the repository at this point in the history

  3. Fix build error 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    c258ef2 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2022

  1. Merge branch 'ign-transport11' into ivanpauno/parameters-component11

    @caguero
    caguero committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    1bcb2e4 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. Use return codes instead of exceptions 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    8e66083 View commit details
    Browse the repository at this point in the history

  2. Remove commented out code, renaming 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    34ee98e View commit details
    Browse the repository at this point in the history

  3. Update docs 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    cd6053f View commit details
    Browse the repository at this point in the history

  4. Add extra info to logs 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    3a0b953 View commit details
    Browse the repository at this point in the history

  5. fix tests + linters 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    f3a36c7 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2022

  1. Remove unnecessary change 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    0d784e1 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2022

  1. Maybe fix windows issue 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    be51729 View commit details
    Browse the repository at this point in the history

  2. Second try 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    16f2420 View commit details
    Browse the repository at this point in the history

  3. Renaming 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    58b3608 View commit details
    Browse the repository at this point in the history

  4. More renaming, docs 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    15a72a9 View commit details
    Browse the repository at this point in the history

  5. test cases for ParameterResult 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    6c5df2a View commit details
    Browse the repository at this point in the history

  6. another try to fix windows 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    be44635 View commit details
    Browse the repository at this point in the history

  7. fix 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    76a4c30 View commit details
    Browse the repository at this point in the history

  8. Fix linter issues 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    81c1a0c View commit details
    Browse the repository at this point in the history