Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz CMake, Python, Partial Source, and File Migrations : gz-transport #328

Merged
merged 2 commits into from
Jul 13, 2022
Merged

ign -> gz CMake, Python, Partial Source, and File Migrations : gz-transport #328

merged 2 commits into from
Jul 13, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon mentioned this pull request Jul 12, 2022
Closed
32 tasks
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jul 12, 2022
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

1 similar comment
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

@methylDragon methylDragon force-pushed the ci_matching_branch/file_and_source_migration branch from fd1f3b3 to 8be976f Compare July 12, 2022 20:56
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

1 similar comment
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

@codecov
Copy link

codecov bot commented Jul 13, 2022 •
edited
Loading

Codecov Report

Merging #328 (8be976f) into main (87632f6) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 8be976f differs from pull request most recent head 8cd0c3e. Consider uploading reports for the commit 8cd0c3e to get more accurate results

@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
- Coverage   88.36%   88.32%   -0.05%     
==========================================
  Files          52       52              
  Lines        4848     4848              
==========================================
- Hits         4284     4282       -2     
- Misses        564      566       +2
Impacted Files Coverage Δ
src/NetUtils.cc 72.89% <ø> (ø)
src/NodeShared.cc 77.76% <100.00%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87632f6...8cd0c3e. Read the comment docs.

@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jul 13, 2022
chapulina
chapulina approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The Windows CI failed twice with what looks like infra failures though. Let's make sure it passes before merging.

@methylDragon
Move dockerfile (#328)
035a530 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Partial cmake and source migrations (#328)
8cd0c3e 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the ci_matching_branch/file_and_source_migration branch from 8be976f to 8cd0c3e Compare July 13, 2022 08:54
@methylDragon
Copy link
Contributor Author

Merging, win is unstable from protobuf warnings, no more infra failures!

@methylDragon methylDragon merged commit d2aa137 into main Jul 13, 2022
@methylDragon methylDragon deleted the ci_matching_branch/file_and_source_migration branch July 13, 2022 20:20
methylDragon added a commit that referenced this pull request Jul 13, 2022
@methylDragon
Move dockerfile (#328)
aad3398 
Signed-off-by: methylDragon <methylDragon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@caguero caguero Awaiting requested review from caguero caguero is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina